Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assets and tests #3

Merged
merged 22 commits into from
Nov 15, 2023
Merged

Add assets and tests #3

merged 22 commits into from
Nov 15, 2023

Conversation

safoinme
Copy link
Collaborator

No description provided.

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 19.3%, saving 33.80 KB.

Filename Before After Improvement Visual comparison
assets/deploy_pipeline.png 41.00 KB 33.13 KB -19.2% View diff
assets/promote_pipeline.png 48.41 KB 39.01 KB -19.4% View diff
assets/training_pipeline.png 85.82 KB 69.29 KB -19.3% View diff

2 images did not require optimisation.

@avishniakov
Copy link
Contributor

I'm not very sure why it was behaving like this (don't have access to repo settings to check), but check out in composite action was not picking ref properly, and tried to check out the main instead of the PR branch - added explicit ref from main ci flow.
I also removed the commit to develop from triggers, since you develop directly in this branch.

@safoinme safoinme merged commit efb688a into main Nov 15, 2023
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants